Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1929. Visualizations for Instructors #1440

Closed
wants to merge 90 commits into from
Closed

Conversation

gshugh
Copy link

@gshugh gshugh commented Apr 16, 2019

Add review rubric statistics to assignment grades view.

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Apr 16, 2019

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

3 Warnings
⚠️ Your pull request is more than 500 LoC.
Please make sure you did not commit unnecessary changes, such as schema.rb, node_modules, change logs.
⚠️ You modified spec/factories/ folder; please double-check whether it is necessary.
⚠️ One or more of your tests do not have expectations or you commented out some expectations.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write at least one expectation for each test and do not comment out expectations.
In your tests, there are many expectations of elements on pages, which is good.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write more expectations to validate other things, such as database records, dynamically generated contents.
You are modifying Gemfile or Gemfile.lock, please double check whether it is necessary.
You are suppose to add a new gem only if you have a very good reason. Try to use existing gems instead.
Please revert changes to Gemfile.lock made by the IDE.
You are using global variables ($) or class variables (@@); please double-check whether this is necessary.
Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.

Generated by expertiza-bot

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Apr 16, 2019

Hey @gshugh,
Your changes look good to me! 🎉

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 46.766% when pulling 4be091b on gshugh:OSS-HW4 into 3de75e1 on expertiza:beta.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 46.766% when pulling 4be091b on gshugh:OSS-HW4 into 3de75e1 on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 46.766% when pulling 4be091b on gshugh:OSS-HW4 into 3de75e1 on expertiza:beta.

@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage decreased (-2.2%) to 49.37% when pulling d201982 on gshugh:OSS-HW4 into 3de75e1 on expertiza:beta.

gshugh and others added 23 commits April 18, 2019 21:05
…ic statistics view has everything hard coded.
… than selected. Filled in a little more of the outline.
… down and checkbox options have NOT been dynamically set yet.
…r instance variables in the view. Changed some of the variable names to better reflect their usage.
Add a questionnaire_rounds method to the Assignment model class
Mock model data implementation
…e data structure to create the string arrays for the menus.
cladkins-ncsu and others added 27 commits April 26, 2019 15:47
…in grade_interface_spec. Fix some Code Climate issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants